[fix] modernize the code #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` npm install -g jscodeshift git clone https://github.com/cpojer/js-codemod.git ``` ``` jscodeshift -t js-codemod/transforms/no-vars.js .\lib\temp.js ```
``` jscodeshift -t js-codemod/transforms/template-literals.js lib ```
``` jscodeshift -t js-codemod/transforms/use-strict.js lib ```
|
Reviewing this tomorrow night 🤙🏼 |
|
The changes were quite straight forward and the tests are passing. Let me know if there is a question. |
|
next up: use nodes built in mkdir instead of the mkdirp package |
|
Is there any interest in getting help getting this over the finish line? I can also help updating or removing the old dependencies on mkdirp and rimraf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the code using modern JavaScript and also fixing some of the performance issues.
The first three commits were automatic using
jscodeshift, and the last one was manual.The tests passing: