Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rts: various speedups #58

Closed
wants to merge 9 commits into from
Closed

Conversation

snakpak
Copy link
Contributor

@snakpak snakpak commented Oct 8, 2018

This pull is a collection of patches. I thought I'd throw it out there to show where I'm at now.

It includes:

  • The pending whitespace tidy patch.
  • The sleeper patch for out of order sigcont/sigterm, rebased to current master.
  • Some svscan tests for the recent sigterm handler addition.
  • A Solaris portability fix for the new supervise-start test.
  • The addition of a makefifo program, strictly for use in rts. (Is mkfifo portable?)
  • Addition of sleeper switches to facilitate better test integration.
  • A proposed patch for Issue "svc -d . ; svc -u ." doesn't restart a service if the service doesn't exit quickly #20. Partially fixed in 7569393, but still failed to restart if the service exited 100. This patch fixes that and adds tests for exit codes 0, 1, and 100.
  • A change in the way supervise handles throttling, switching to iopause instead of deepsleep, eliminating the one second of unresponsiveness each time a child starts or stops.
  • Various rts tweaks, reducing run time to around 10 sec.

And that would bring me to the end of meeting my goals on this -- the "missing sigcont" issue and speeding up the tests -- with a couple extras thrown in just because I already had my head wrapped around it. =)

@josb
Copy link

josb commented Oct 10, 2018

Thanks for addressing #20 !

@snakpak
Copy link
Contributor Author

snakpak commented Oct 10, 2018

As mentioned in #20 the sleeper -d switch wasn't working correctly. That's fixed and rebased in PR #59.

@snakpak snakpak closed this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants