Add support for DockerHub auto-builds (fixes #1178) #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for automated DockerHub builds in the Dockerfile. This is composed of three changes 1) Dockerfile and related files are moved into a dediated directory 2) a DockerHub-dedicated hooks/build file is added and 3) Testing is disabled in the Dockerfile to speed up the build.
|
Cool! I think -- I'm not sure I understand the implications. Just to make sure: Accepting this PR does not obligate me to do anything with Docker (yet); is that correct? |
|
@tkw1536 maybe you could enumerate which/if any steps are needed here to enable the auto-builds once the PR is merged? I think it's a pretty safe PR to land in master, even if the configure takes a little bit of time to figure out, nothing existing should be affected. |
|
@brucemiller Correct, yes this PR itself does not obligate you to do anything Docker. The commit mere adds support to do it at all. @dginev with this PR merged, to enabled DockerHub autobuilds one has to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've re-read the DockerHub documentation and figured out that it does support custom build hooks. As such, I have to revise #1178 (comment). With this PR I would like to merge a branch that has auto-builds (i.e. docker image build on every push) enabled. The generated images can be found at tkw01536/latexml.
To speed up the build process I made the following two optimizations:
--build-arg WITH_TEXLIVE=no)cpanm --notest .)With these optimizations, building seems to take between 10-20 minutes for each commit.
Please note that deploying DockerHub auto-builds for the main LaTeXML repository will require someone with Owner rights on the GitHub repository to configure them.