allow stylesheets to read and write files in the site directory #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xworld21
commented
Sep 3, 2022
xworld21
commented
Oct 10, 2022
xworld21
force-pushed
the
exsl-document-site-directory
branch
from
2b54ca2
to
f7d837e
Compare
This was referenced Mar 4, 2023
xworld21
force-pushed
the
exsl-document-site-directory
branch
from
f7d837e
to
ddc4d46
Compare
|
I have removed the libxslt security callback stuff, and kept this PR at a minimum: the point is, XSLT.pm is supposed to run in the site directory, because stylesheets can create additional files via The security callbacks will reappear in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small functionality
& security improvement, while working on #1948: stylesheets can read (viadocument()) and write (via<exsl:document>) files. This PR ensures that read/write operations happen in the site directory.For security, operations are also restricted to the site directory, and network access is disabled.Edit: this fixes #2053 in so far as letting
exsl:document()write files in the correct place. My sandbox question in #2053 should rather be part of #2218.