notepad.runMenuCommand in Hebrew

[Yaron10]

Hello Dave,

When Notpad++ Interface Language is set to English, the following script is executed successfully.

notepad.runMenuCommand("View", "Word wrap")

However, I couldn't find a way to run that script if the Interface Language is set to Hebrew.
I've tried various ".decode('utf8')" commands, but to no avail.

Thank you for this great plugin.

[Yaron10]

notepad.menuCommand(MENUCOMMAND.VIEW_WRAP)

Works even if the Interface Language is set to Hebrew.

[chcg]

@Yaron10 How is in case of Hebrew the command equivalent to

notepad.runMenuCommand("View", "Word wrap")

written and which direction do you use? RTL?

[Yaron10]

Hello @chcg,

Thanks for replying. I appreciate it.
And many thanks you for your work on this plugin. 👍

The command in Hebrew is notepad.runMenuCommand("תצוגה", "גלילת שורות").
It works from the console but not within a script.

I use NPP in Hebrew and the layout is RTL.

---

Two related request:

1) Could you set the console layout to LTR even if NPP layout is RTL?
Please see this discussion (the RTL part).
@ClaudiaFrank kindly found the relevant code (thanks again Claudia).

• As I've mentioned in that thread, Dave uploaded PythonScript v1.1.1 without committing the changes.
  Have you committed the fix included in v1.1.1?

2) Could you add Unicode support to the menu?
Hebrew file-names are displayed as gibberish.

---

Allow me two more questions:

1) Dave's latest official version is 1.0.8.0. Why did you start with 0.6.3.0?

2) I've downloaded your latest PythonScript_Full_1.0.9.0.zip and replaced the DLL and the lib folder.
from ctypes import windll, byref, wintypes, WINFUNCTYPE, Structure, sizeof in startup.py triggers an error.
Why is that?

---

Thanks also for your contribution to ComparePlugin. :)

Best regards.

Yaron, what error do you get?
How is your python (not python script) setup? Local version or the dll from the zip.
Short test

Why do you think 1.0.9.0 was created out from 0.6.3??

[Yaron10]

Hello Claudia,

Thanks for replying. I appreciate it.

I'm using the DLL from the zip package.
I've replaced python27.dll and PythonScript.dll with the new ones.

I don't get the error now. It was certainly there a few hours ago.

However, NPP consistently hangs when I'm using the following script.

if RIGHT_CLICK_MODE:
	console.hide()
	editor.grabFocus()
else:
	console.show()

With the following startup.py (thanks again :) ).

# The lines up to and including sys.stderr should always come first
# Then any errors that occur later get reported to the console
# If you'd prefer to report errors to a file, you can do that instead here.
import sys
from Npp import *

# Set the stderr to the normal console as early as possible, in case of early errors
sys.stderr = console

# Define a class for writing to the console in red
class ConsoleError:
	def __init__(self):
		global console
		self._console = console;

	def write(self, text):
		self._console.writeError(text);

# Set the stderr to write errors in red
sys.stderr = ConsoleError()

# This imports the "normal" functions, including "help"
import site

# This sets the stdout to be the currently active document, so print "hello world",
# will insert "hello world" at the current cursor position of the current document
sys.stdout = editor

##################### Right-click mode and Change console output to LTR. #####################

# See https://notepad-plus-plus.org/community/topic/13510/python-lua-script-detect-if-a-modifier-is-pressed-when-running-a-script.

# console.write('parent:{}\n'.format(parent))

from ctypes import windll, byref, wintypes, WINFUNCTYPE, Structure, sizeof

WNDENUMPROC = WINFUNCTYPE(wintypes.BOOL,
                          wintypes.HWND,
                          wintypes.LPARAM)

WndProcType = WINFUNCTYPE(wintypes.LONG,
                          wintypes.HWND,
                          wintypes.UINT,
                          wintypes.WPARAM,
                          wintypes.LPARAM)

GWL_WNDPROC = -4
RIGHT_CLICK_MODE = False

GWL_EXSTYLE = -20
WS_EX_LAYOUTRTL = 0x00400000

class NPPchildWindows():

	def EnumNPPCallback(self, hWnd, lParam):
		curr_class = (wintypes.WCHAR * 256)()
		windll.user32.GetClassNameW(hWnd, curr_class, 256)

		if lParam == 0:
			if curr_class.value.lower() == "toolbarwindow32":
				self.toolbar_handle = hWnd
				return False
		else:
			curr_name = (wintypes.WCHAR * 256)()
			windll.user32.GetWindowTextW(hWnd, curr_name, 256)
			if curr_name.value.lower() == "python script":
				self.python_script_hwnd = hWnd
			elif curr_class.value.lower() == "scintilla" and windll.user32.GetParent(hWnd) == self.python_script_hwnd:
				self.python_script_sci_handle = hWnd
				return False

		return True

	def __init__(self):
		self.toolbar_handle = None
		self.oldWndProc = None
		self.python_script_hwnd = None
		self.python_script_sci_handle = None

		parent = windll.user32.FindWindowA("Notepad++", None)
		windll.user32.EnumChildWindows(parent, WNDENUMPROC(self.EnumNPPCallback), 0)
		console.show()
		windll.user32.EnumChildWindows(parent, WNDENUMPROC(self.EnumNPPCallback), 1)

	def registerRightClick(self):
		if self.toolbar_handle:
			self.new_wnd_proc = WndProcType(self.sciWndProc)
			self.oldWndProc = windll.user32.SetWindowLongA(self.toolbar_handle, GWL_WNDPROC, self.new_wnd_proc)
			console.write("Toolbar right-click mode registered.\n\n")

	def sciWndProc(self, hWnd, msg, wParam, lParam):
		global RIGHT_CLICK_MODE
		if msg == 0x0204:		# WM_RBUTTONDOWN.
			windll.user32.mouse_event(0x0002, 0, 0, 0, 0)	# Left down. WM_RBUTTONUP is sent although the right button is still down.
		elif msg == 0x0205:	# WM_RBUTTONUP.
			if RIGHT_CLICK_MODE:		# Another WM_RBUTTONUP is sent when the right button is released. Send "Left up" now.
				windll.user32.mouse_event(0x0004, 0, 0, 0, 0)	# Left up.
			else:	# The right button is still down.
				RIGHT_CLICK_MODE = True
		elif RIGHT_CLICK_MODE and msg == 0x0201:		# WM_LBUTTONDOWN.
			RIGHT_CLICK_MODE = False

		return windll.user32.CallWindowProcA (self.oldWndProc, hWnd, msg, wParam, lParam)

	def consoleToLTR(self):
		if self.python_script_sci_handle:
			exStyle = windll.user32.GetWindowLongA(self.python_script_sci_handle, GWL_EXSTYLE)
			exStyle = exStyle ^ WS_EX_LAYOUTRTL
			windll.user32.SetWindowLongA(self.python_script_sci_handle, GWL_EXSTYLE, exStyle);
			console.write("Console output changed to LTR.\n\n")

_NPPchildWindows = NPPchildWindows()
_NPPchildWindows.registerRightClick()
_NPPchildWindows.consoleToLTR()

console.hide()
editor.grabFocus()

I've added several right/left toolbar buttons (using CustomizeToolbar; executing various scripts) and they all work properly except the Show/Hide one.

Actually, just using console.show() causes NPP to hang.
Reverting to the original startup.py, console.show() works as expected.

Replacing the new PythonScript.dll with the old one - the Show/Hide button works properly.

---

Why do you think 1.0.9.0 was created out from 0.6.3??

https://github.com/bruderstein/PythonScript/releases

0.6.3 was released a few days ago and I was just wondering why those numbers were chosen when 1.0.8.0 was out a few years ago. Isn't that confusing?

Best regards.

Isn't that confusing?

Ah, I see - you are right but I guess this is related to appveoy automatically pushing the artifacts
but chcg would know better. I will take a look to your issue and see if I can find out what it is causing it.

[Yaron10]

Great. 👍
Thank you very much.

Would you mind restart npp, show console and post the output?

[Yaron10]

Toolbar right-click mode registered.

Console output changed to LTR.

Python 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:19:30) [MSC v.1500 32 bit (Intel)]
Initialisation took 47ms
Ready.

Thanks.

ok - and problem still exists?
The reason why I'm asking is that I can only reproduce it if python script dll and python dll
are from different builds like new 1.0.9.0 python script and old python dll from 1.0.8.0

[Yaron10]

Yes, it does.
I've tried those combinations. :)

You took the zip - you didn't build it yourself, didn't you?

[Yaron10]

The original zip.

[Yaron10]

And it also happens with the original NPP.

It seems toolbar related