upgrade to 5.0.0-alpha4 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import org.elasticsearch.action.termvectors.TermVectorsRequest; | ||
| import org.elasticsearch.search.fetch.FetchSubPhaseContext; | ||
|
|
||
| public class AnalyzedTextFetchContext extends FetchSubPhaseContext { |
There was a problem hiding this comment.
Wait. Why does this have to go too?
There was a problem hiding this comment.
Oops, got carried away, I guess.
|
Again, you cannot imagine how happy this makes me! I do not think it makes sense to review much because the code was untidy before and it is just a prototype anyway. I left a few questions though. |
|
I've restored the analyzed text sub phase that I accidentally deleted. Sorry about that. |
|
LGTM! |
This commit also removes analyzed_text mapper, naive bayes update script and spark mllib dependencies, which turned out to be too problematic for the upgrade. Since in 5.0 only one scripting engine per plugin is allowed the prep spec scripting engine was transformed into a native script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also removes analyzed_text mapper, naive bayes update script and spark mllib dependencies, which turned out to be too problematic for the upgrade. Since in 5.0 only one scripting engine per plugin is allowed the prep spec scripting engine was transformed into a native script.