Assorted tweaks and updates #173

XhmikosR · 2021-04-05T05:50:13Z

@bryanbraun Please don't squash this and don't let it hanging for a long time :)

Let me know if you need me to make any changes.

Notes:

I didn't update the dist files, etc, but after merging this, a new patch release would be perfect.
Ideally, we should have karma run for the minified file just to be 100% safe, but that's for another time (we should have an issue to track it)
We could add coverage support later

Manual Preview: https://sleepy-noyce-bed069.netlify.app

XhmikosR · 2021-04-05T05:51:05Z

docs/scripts.js


-  for(var i = 0; i < toggleButtons.length; i++) {
-    toggleButtons[i].addEventListener("click", slideExampleCode); // add the event to each button
+  for (var i = 0; i < toggleButtons.length; i++) {


I could probably use one variable, but I went with the way I'd go if this was a let variable. Feel free to change it later :)

XhmikosR · 2021-04-05T05:55:18Z

test/visual-check.html

@@ -39,7 +39,6 @@
 </head>
 <body>
  <section class="main">
-    <a href="https://github.com/bryanbraun/anchorjs"><img style="position: absolute; top: 0; right: 0; border: 0;" src="https://github-camo.global.ssl.fastly.net/365986a132ccd6a44c23a9169022c0b5c890c387/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f6769746875622f726962626f6e732f666f726b6d655f72696768745f7265645f6161303030302e706e67" alt="Fork me on GitHub" data-canonical-src="https://s3.amazonaws.com/github/ribbons/forkme_right_red_aa0000.png"></a>
    <h1 class="page-title">AnchorJS</h1>
    <div class="anchorjs-logo"></div>


We could probably remove this too or use the SVG file, but I thought I'd leave this to you :)

XhmikosR · 2021-04-05T06:04:22Z

test/load-order-3.html

@@ -32,7 +32,7 @@
 <body>
  <section class="main">
    <h1>A page with large images (delays after DOMContentLoaded).</h1>
-    <img src="http://lorempixel.com/1600/1600/" alt="Large image">
+    <img src="https://loremflickr.com/1600/1600/" alt="Large image">


I don't get a 1600x1600 image, though, but I don't have a replacement in mind. Feel free to adapt this later :)

Gotcha. This is definitely an improvement.

XhmikosR · 2021-04-06T05:15:38Z

anchor.js

@@ -244,8 +244,7 @@

      // Regex for finding the non-safe URL characters (many need escaping):
      //   & +$,:;=?@"#{}|^~[`%!'<>]./()*\ (newlines, tabs, backspace, vertical tabs, and non-breaking space)
-      var nonsafeChars = /[& +$,:;=?@"#{}|^~[`%!'<>\]./()*\\\n\t\b\v\u00A0]/g,
-          urlText;


I can revert the temp var removal; I thought it helped with uglify but apparently it doesn't. So, if it's more clear for you with the temp var, let me know and I'll revert it.

I think it's good without the temp variable. 👍

So that we are consistent and that it's more readable.

XhmikosR · 2021-04-08T06:02:28Z

docs/index.html

@@ -19,7 +19,7 @@
  <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:200,400,700&display=swap">
  <link rel="stylesheet" href="styles.css">
  <link rel="stylesheet" href="fonts/fonts.css">
-  <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/prismjs@1.21.0/themes/prism-twilight.css">
+  <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/prismjs@1.23.0/themes/prism-twilight.css">


This update fixes IE 11 errors among other things

Also, manually fix the npmjs redirected links.

Specify `--continue-on-error` and `--aggregate-output` and run scripts in parallel.

Saves a few more bytes.

This is (was) needed for IE.

They were accidentally removed in 60d3a79.

This is needed for IE 11.

* eslint ^7.17.0 → ^7.24.0 * karma ^5.2.3 → ^6.3.2 * lockfile-lint ^4.3.7 → ^4.6.2 * uglify-js ^3.12.4 → ^3.13.4

bryanbraun

These are really great changes all around! Thanks for your patience waiting until I could get to it. I'll merge it and roll out a patch update shortly. 👍

bryanbraun · 2021-04-17T20:03:26Z

anchor.js

@@ -244,8 +244,7 @@

      // Regex for finding the non-safe URL characters (many need escaping):
      //   & +$,:;=?@"#{}|^~[`%!'<>]./()*\ (newlines, tabs, backspace, vertical tabs, and non-breaking space)
-      var nonsafeChars = /[& +$,:;=?@"#{}|^~[`%!'<>\]./()*\\\n\t\b\v\u00A0]/g,
-          urlText;


I think it's good without the temp variable. 👍

bryanbraun · 2021-04-17T20:08:07Z

test/load-order-3.html

@@ -32,7 +32,7 @@
 <body>
  <section class="main">
    <h1>A page with large images (delays after DOMContentLoaded).</h1>
-    <img src="http://lorempixel.com/1600/1600/" alt="Large image">
+    <img src="https://loremflickr.com/1600/1600/" alt="Large image">


Gotcha. This is definitely an improvement.

Bump year

46dc37f

XhmikosR commented Apr 5, 2021

View reviewed changes

XhmikosR marked this pull request as ready for review April 5, 2021 05:51

XhmikosR commented Apr 5, 2021

View reviewed changes

XhmikosR changed the title ~~Dev patches~~ Assorted tweaks and updates Apr 5, 2021

XhmikosR commented Apr 6, 2021

View reviewed changes

Use uppercase escape sequences.

4341882

So that we are consistent and that it's more readable.

XhmikosR commented Apr 8, 2021

View reviewed changes

XhmikosR added 17 commits April 8, 2021 09:10

banner.js: minor tweaks

b3a0779

docs: fix redirected URL and use rel=noopener

8df48c7

docs/scripts.js: minor consistency tweaks

9555869

test/visual-check.html: remove the old fork me image

b5e4d6f

test files: minor HTML consistency changes

db34de3

Use https when possible

05b3f5a

Fix broken link

cf7400e

tests: Update jQuery to v3.6.0.

5147443

Remove temporary variable.

8b52205

Rename karma config file and update it from karma init

c939382

Also, manually fix the npmjs redirected links.

Update npm-run-all test command

23290cc

Specify `--continue-on-error` and `--aggregate-output` and run scripts in parallel.

uglify: use 2 passes

36639bb

Saves a few more bytes.

docs: update prismjs to v1.23.0.

9cadf94

docs: add border: 0

958e4fd

This is (was) needed for IE.

docs: add missing CSS prefixes for IE.

39e4635

They were accidentally removed in 60d3a79.

docs: add width for .example

dd4c650

This is needed for IE 11.

Update devDependencies

61d7d08

* eslint ^7.17.0 → ^7.24.0 * karma ^5.2.3 → ^6.3.2 * lockfile-lint ^4.3.7 → ^4.6.2 * uglify-js ^3.12.4 → ^3.13.4

bryanbraun approved these changes Apr 17, 2021

View reviewed changes

bryanbraun merged commit 8961d72 into bryanbraun:master Apr 17, 2021

XhmikosR deleted the dev branch April 18, 2021 05:29

renovate bot mentioned this pull request May 21, 2021

fix(deps): update dependency anchor-js to v4.3.1 lacolaco/blog.lacolaco.net#22

Merged

1 task

renovate bot mentioned this pull request May 21, 2021

Update dependency anchor-js to v4.3.1 nfriend/website-3.0#51

Closed

1 task

renovate bot mentioned this pull request Jun 6, 2021

Update dependency anchor-js to v4.3.1 - autoclosed nownabe/blog.nownabe.com#68

Closed

1 task

renovate bot mentioned this pull request Jul 27, 2021

Update dependency anchor-js to v4.3.1 NordicSemiconductor/pc-nrfconnect-docs#17

Merged

1 task

Mhmonicox mentioned this pull request May 24, 2024

[Snyk] Upgrade anchor-js from 4.2.0 to 4.3.1 Mhmonicox/jenkins.io#18

Open

Mhmonicox mentioned this pull request Sep 10, 2024

[Snyk] Upgrade: anchor-js, bootstrap, ionicons, jquery, popper.js, tether Mhmonicox/jenkins.io#20

Open

WontonSam mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: anchor-js, autoprefixer, cssnano, github-markdown-css, postcss, postcss-cli, sass, webpack, webpack-cli WontonSam/conventionalcommits.org#16

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assorted tweaks and updates #173

Assorted tweaks and updates #173

XhmikosR commented Apr 5, 2021 •

edited

Loading

XhmikosR Apr 5, 2021

XhmikosR Apr 5, 2021

XhmikosR Apr 5, 2021

bryanbraun Apr 17, 2021

XhmikosR Apr 6, 2021

bryanbraun Apr 17, 2021

XhmikosR Apr 8, 2021

bryanbraun left a comment

bryanbraun Apr 17, 2021

bryanbraun Apr 17, 2021

Assorted tweaks and updates #173

Assorted tweaks and updates #173

Conversation

XhmikosR commented Apr 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bryanbraun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XhmikosR commented Apr 5, 2021 •

edited

Loading