add '<' and '>' to nonsafeChars #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I should be able to look at this later this week. 👍 |
|
Just tested this out. It looks great! I'll updating our tests to include these characters, and merge it. I probably won't release a new version of the library immediately, since it's a possible breaking change for existing URLs and I'd like to batch the release with a couple other updates with breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anchorjs will fail Bootstrap's Scrollspy when the generated
idcontains<or>, because it has special meaning in CSS. See jQuery's Selectors. All the meta-charactors mentioned(!"#$%&'()*+,./:;<=>?@[\]^`{|}~) have been included in anchorjs's nonsafeChars, except<and>. I suggest adding them for better compatibility.