This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Fix isleftcanonical
and isrightcanonical
to work for boundary tensors
#29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the
isleftcanonical
(isrightcanonical
) function does not work for the right(left)-mostTensor
in aChain
. In this PR, we fix this by adding a "dummy" extra dimension to these boundary tensors, in order to be able to check their canonical form.