-
Notifications
You must be signed in to change notification settings - Fork 0
Extend evolve!
for Chain
in canonical form
#31
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 71.74% 68.62% -3.13%
==========================================
Files 8 8
Lines 499 529 +30
==========================================
+ Hits 358 363 +5
- Misses 141 166 +25 ☔ View full report in Codecov by Sentry. |
src/Ansatz/Chain.jl
Outdated
""" | ||
contract_θ!(ψ::Chain, site::Site) | ||
|
||
For a [`Chain`](@ref) in the canonical form, forms the two-site wave function θ with ΛᵢΓᵢΛᵢ₊₁Γᵢ₊₁Λᵢ₊₂, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be less confusing if you use the notation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This for me is not ideal, I put the subindices there to explicitly show which
src/Ansatz/Chain.jl
Outdated
delete!(TensorNetwork(ψ), Γᵢ) | ||
delete!(TensorNetwork(ψ), Λᵢ₊₁) | ||
delete!(TensorNetwork(ψ), Γᵢ₊₁) | ||
|
||
push!(TensorNetwork(ψ), θ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be careful about this. Wouldn't it be better to call contract!
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, it makes more sense to directly replace these three with θ
.
I'd merge this. I have tested locally and everything works fine. @mofeing |
Summary
This PR extends the
evolve!
function forChain
s in the canonical form.