This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Enhance contract
to support keyword arguments during reduction
#32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following from the PR #31, this PR modifies the
contract(tensors...)
function to supportkwargs
, therefore allowing them to be passed to thecontract(tensor1, tensor2)
function.This change is useful since
Tenet.contract(expr::EinExpr)
calls thecontract
method with thedims
keyword argument, leading to an error due to the absence of handlingkwargs
in thecontract(tensors...)
function.With this update, the
dims
argument (as well as other potential keyword arguments) can be appropriately handled during the tensor contraction process.