Fix not able to query IPv6 DNS servers because of too many colons in address
#30
Conversation
pkg/core/core.go
Outdated
| } | ||
| // If the server IP is IPv6, wrap it in square brackets to remove ambiguity from port number and address. | ||
| if net.ParseIP(dnsServerIP).To4() == nil { | ||
| dnsServerIP = "[" + dnsServerIP + "]" |
There was a problem hiding this comment.
Recommendation: I suggest checking whether the parsed dnsServerIP includes a trailing port. If it does, we should use the IP along with the trailing port. If there's no trailing port, consider appending :53 to the dnsServerIP.
Additionally, we should address another issue by allowing the user to pass a custom port through the --dns-server-ip flag. This would ensure support for a broader range of possibilities when wanting to query your own DNS server, folks tend to typically do so because they have either a custom port or use IPv6 for instance.
I'm curious to hear what you think. Also, I have doubts about the bracket notation; it seems a bit unclear, vague and not that 'clean' to me.
There was a problem hiding this comment.
I've updated the PR to address your comment regarding the custom ports.
Besides that, I've cleaned up the implementation. JoinHostPort(..) does the exact same validation as I implemented before, but all in a single line 😄
bschaatsbergen
added
the
waiting-response
|
Very nice fix @mmourick 👍🏼 |
bschaatsbergen
removed
the
waiting-response
What
dnsServerIPwhen using IPv6 addresses.dns-server-portflag to let users specify a port other than the default of53.Why
:53port specification of the URI creates ambiguity when used in combination with IPv6 addresses. The square bracket notation is used to resolve this. Refer to RFC3986 for more details.References
1004:520:4e42:2000::53:53:too many colons in address #26--dns-server-ip#31