Fix PHP 8.1 deprecation error #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Ocramius
suggested changes
May 11, 2022
Ocramius
reviewed
May 13, 2022
Ocramius
approved these changes
May 13, 2022
snapshotpl
force-pushed
the
fix-deprecation-error
branch
from
8cbc0d5 to
944bdb3
Compare
|
@bshaffer Can you look at? |
bshaffer
requested changes
May 31, 2022
There was a problem hiding this comment.
@snapshotpl this is causing the tests to fail. that is because there is a $contentType !== null check a few lines below your change which is now failing when it should succeed. The better solution would be to cast $contentType to a string when calling strpos
src/OAuth2/TokenType/Bearer.php
Outdated
| @@ -108,7 +108,7 @@ public function getAccessTokenParameter(RequestInterface $request, ResponseInter | |||
| return null; | |||
| } | |||
|
|
|||
| $contentType = $request->server('CONTENT_TYPE'); | |||
| $contentType = $request->server('CONTENT_TYPE', ''); | |||
| if (false !== $pos = strpos($contentType, ';')) { | |||
There was a problem hiding this comment.
Suggested change
| if (false !== $pos = strpos($contentType, ';')) { | |
| if (false !== $pos = strpos((string) $contentType, ';')) { |
src/OAuth2/TokenType/Bearer.php
Outdated
| @@ -108,7 +108,7 @@ public function getAccessTokenParameter(RequestInterface $request, ResponseInter | |||
| return null; | |||
| } | |||
|
|
|||
| $contentType = $request->server('CONTENT_TYPE'); | |||
| $contentType = $request->server('CONTENT_TYPE', ''); | |||
There was a problem hiding this comment.
Suggested change
| $contentType = $request->server('CONTENT_TYPE', ''); | |
| $contentType = $request->server('CONTENT_TYPE'); |
snapshotpl
force-pushed
the
fix-deprecation-error
branch
from
944bdb3 to
b7e2bdf
Compare
bshaffer
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when test on PHP 8.1 here https://github.com/laminas-api-tools/api-tools-oauth2/runs/6385928373?check_suite_focus=true#step:3:677