Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces deprecated DynomoDbClient’s formatAttribute function #1035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adonix
Copy link

@adonix adonix commented Nov 11, 2022

  1. The DynomoDbClient::formatAttributes function has been deprecated and its suggested fix is to use the function marshalItem from AWS DynomoDb’s Marshaler class.
  2. When upgrading to AWS SKD PHP V3, it forces to update guzzle, which in turn will use the AWS Result class that now returns two items in its array: item and @metadata. Thus, fixed DynamoDb::ClientCredentials() to not use $result->count() == 1 anymore. However, this fix is still compatible with AWS SDK PHP V2 since it will use guzzle's common Collection class:

public function hasKey($key) { return array_key_exists($key, $this->data); }

1) The DynomoDbClient::formatAttributes function has been deprecated and suggested fix is to use the function marshalItem from AWS DynomoDb’s Marshaler class.
2) When upgrading to AWS SKD PHP V3, it forces to update guzzle, which in turn will use AWS Result class that now returns two items in its array: item and @metadata. Thus, fixed DynamoDb::ClientCredentials() to not use $result->count() == 1 anymore.

Signed-off-by: Enrique Figueroa <elder.e.figueroa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant