Update to current Mongo PHP Library #769
Conversation
|
Since the minimum PHP requirement for this library is My library is in it's very early stages and should not be used for production code at this time. |
|
This is a bit irritating. Did the Travis build fail for my PR or did it not? |
|
@memmaker your build is failing because the |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "bshaffer/oauth2-server-php", | |||
| "name": "memmaker/oauth2-server-php", | |||
There was a problem hiding this comment.
Please revert the changes made to composer.json
| ), $config); | ||
| } | ||
|
|
||
| // Helper function to access a MongoDB collection by `type`: | ||
| protected function collection($name) | ||
| { | ||
| return $this->db->{$this->config[$name]}; | ||
| //return $this->db->{$this->config[$name]}; |
| OpenIDAuthorizationCodeInterface | ||
| { | ||
| protected $db; | ||
| protected $config; | ||
|
|
||
| public function __construct($connection, $config = array()) | ||
| { | ||
| if ($connection instanceof \MongoDB) { | ||
| if ($connection instanceof MongoDB\Database) { |
There was a problem hiding this comment.
Let's go ahead and add this to a use statement above.
|
These changes use the |
|
@bshaffer you could avoid BC changes by componentizing some of the library such as the mongodb storage. Users could pick and choose what storage implementation they wanted. Also it would be easier to test the smaller libraries. |
|
I added this for BC and also fixed the tests: #790 PTAL! I agree separate libraries would be better! I will definitely consider splitting these out. |
We also added the missing implementations for the JTI part.