Use OpenSSL random method before attempting Mcrypt's. #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL is faster and libmcrypt has been abandoned since 2003 and is now deprecated in PHP 7.1 anyway.
|
Hi, any news on that? :) |
|
The PR looks good to me 👍 |
|
Just looking to upgrade our system to PHP7 and stumbled across this issue, a merge would be fantastic :) |
|
@bshaffer PHP 7.1 released and deprecated mcrypt |
|
yes please 👍 |
|
Thanks guys! This looks great. |
|
Woops, I need to cut a new release and not merge directly into master. |
bshaffer
pushed a commit
that referenced
this pull request
Dec 23, 2016
|
added to develop in 9124777 |
nanasess
added a commit
to nanasess/eccube-api
that referenced
this pull request
Dec 26, 2016
- EC-CUBE 3.0.12-p1, 3.0.13 をテスト対象に追加 - PHP7.1 をテスト対象に追加 - oauth2-server-php のリリース待ち bshaffer/oauth2-server-php#773 - xdebug の有効/無効を環境変数で設定するよう修正
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL is faster and libmcrypt has been abandoned since 2003 and is now deprecated in PHP 7.1 anyway.