-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added easier method to customize jwt token payload #795
added easier method to customize jwt token payload #795
Conversation
…n of jwt token payload
This is great! I'm being picky here, but I don't think the term |
@bshaffer done. I always have problems choosing names :) thought if we have |
@svycka I don't think tests are necessary for such a small refactoring. As for the name, with the previous examples, the "generate" refers to the randomization of the token ID. In this case, the method is just constructing the payload and not really generating anything. That's my reasoning. |
Thank you for the PR! |
@bshaffer is it possible that this will be merged soon? or should I go with workaround for now? |
Is there an estimated date when this will be in a release? I find it very useful. |
Any word on this? Would be a big help! |
because it is merged an will be released in new version.
…On Sep 7, 2017 6:37 PM, "bluebaroncanada" ***@***.***> wrote:
@svycka <https://github.com/svycka>, can you advise us why you closed
this?
|
Yeah. Sorry. I thought you were saying, "Closed because it's not easy to do." |
@MajesticMaje so if you use the develop branch, you should be all set. |
@MajesticMaje @svycka @bluebaroncanada Sorry for the delay here, we're all tagged up! Please update your dependencies for
|
as suggested in #793
@bshaffer is it something like this?
usage example: