Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds php 7.2 to travis #873

Merged
merged 2 commits into from
Sep 26, 2017
Merged

adds php 7.2 to travis #873

merged 2 commits into from
Sep 26, 2017

Conversation

bshaffer
Copy link
Owner

No description provided.

@bluebaroncanada
Copy link
Collaborator

bluebaroncanada commented Sep 19, 2017

I'm worried this commit or commits like it could cause other logical statements to trigger. For example: null checks.

@bluebaroncanada
Copy link
Collaborator

bluebaroncanada commented Sep 19, 2017

It might not just be internal code that's affected by this change, too.

@bluebaroncanada
Copy link
Collaborator

Never mind. It shouldn't be an issue. My apologies.

@bluebaroncanada
Copy link
Collaborator

Err. Actually it is if $a=[]; $a===null;

@bshaffer
Copy link
Owner Author

You bring up a good point. $server->getResponseType and $server->getGrantType will be returning differently with this change. It may be time we rename master to v1-master, and rename develop to master and merge in the changes from the v2 branch.

@bshaffer bshaffer merged commit 29afbc0 into develop Sep 26, 2017
@bshaffer bshaffer deleted the add-php72 branch September 26, 2017 02:00
@bshaffer
Copy link
Owner Author

@bluebaroncanada This change is very benign. We should look into moving to v2.0 soon, however!

bshaffer added a commit that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants