Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on MSVC. #10

Closed
wants to merge 1 commit into from
Closed

Fix compilation on MSVC. #10

wants to merge 1 commit into from

Conversation

pechy
Copy link

@pechy pechy commented May 25, 2021

Compilation with MSVC fails because of the 'and' keyword, after replacing it with '&&' it works.

Compilation with MSVC fails because of the 'and' keyword, after
replacing with '&&' it works.
@bshoshany
Copy link
Owner

Hmm, it looks like MSVC does not interpret and as && unless the /permissive- or /Za compiler flags are used. That's my bad, I usually check that the code compiles with GCC, Clang, and MSVC before releasing a new version, but I didn't check with MSVC last time.

I release my projects in cumulative updates after editing them locally, so my policy is to not accept pull requests. Instead, I will merge this change into the next release, possibly together with some other changes, and along with a version bump and a corresponding note in README.md. Thanks for your contribution :)

@bshoshany bshoshany closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants