Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mobile banner image #152

Merged
merged 2 commits into from
Feb 5, 2025
Merged

add mobile banner image #152

merged 2 commits into from
Feb 5, 2025

Conversation

antoninodelfiume
Copy link
Contributor

No description provided.

@antoninodelfiume antoninodelfiume self-assigned this Jan 20, 2025
@LukasBSI
Copy link
Contributor

Could you add the releasenotes? :)
And did you check, if our standard elements that extend the banner can handle the additional image-part?

@antoninodelfiume
Copy link
Contributor Author

Could you add the releasenotes? :) And did you check, if our standard elements that extend the banner can handle the additional image-part?

Yep, i saw that the header image element in the main branch already support the mobileSrc attribute

@LukasBSI LukasBSI merged commit d9383c6 into main Feb 5, 2025
@LukasBSI LukasBSI deleted the features/adl/bannermobile branch February 5, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasBSI LukasBSI LukasBSI approved these changes

Assignees

@antoninodelfiume antoninodelfiume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoninodelfiume @LukasBSI