Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--enable-preview through Jabel? #9

Closed
verhas opened this issue Dec 24, 2019 · 1 comment
Closed

--enable-preview through Jabel? #9

verhas opened this issue Dec 24, 2019 · 1 comment

Comments

@verhas
Copy link
Contributor

verhas commented Dec 24, 2019

When I use --enable-preview I cannot start the compilation with Jabel. It complains that Java 13 preview features are not possible to use with Java 8 release.

Could Jabel have an option so that it will also tell the compiler to handle the preview features and still generate Java 8 binary?
@verhas verhas changed the title --enable-preview through Jable? --enable-preview through Jabele? Dec 24, 2019
@verhas verhas changed the title --enable-preview through Jabele? --enable-preview through Jabel? Dec 24, 2019
@lppedd lppedd mentioned this issue Mar 17, 2020
Open
astubbs added a commit to astubbs/jabel that referenced this issue Aug 13, 2020
@astubbs
Fixes bsideup#9 by telling the compiler no features are preview features
77cc5d1
@astubbs astubbs mentioned this issue Aug 13, 2020
Closed
astubbs added a commit to astubbs/jabel that referenced this issue Aug 13, 2020
@astubbs
Fixes bsideup#9 by telling the compiler no features are preview features
4b29f6b
astubbs added a commit to astubbs/jabel that referenced this issue Aug 17, 2020
@astubbs
Fixes bsideup#9 by telling the compiler no features are preview features
67b241d
@bsideup
Copy link
Owner

bsideup commented Sep 17, 2020

Hi @verhas,

Please see the README, it gives an example how to integrate Jabel into your build:
https://github.com/bsideup/jabel/blob/master/README.md

When you set release to 8 the compiler will indeed complain that the preview features cannot be used, but you don't need to enable the flag since Jabel removes the preview flag from them.

@bsideup bsideup closed this as completed Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable preview features astubbs/jabel
2 participants
@bsideup @verhas