Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised import statement for scipy.integrate.trapz #26

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

natsuwater
Copy link
Contributor

As scipy>=1.14.0 has deprecated scipy.integrate.trapz in favour of scipy.integrate.trapezoid, we need to try to import either of them.

Texts in examples.rst and forward.rst are also fixed to show this behaviour.

…grate.trapezoid`.

import statement updated using try / except
@slayoo
Copy link

slayoo commented Oct 20, 2024

@bsumlin, it would be great to merge this PR to address #25

@slayoo
Copy link

slayoo commented Dec 5, 2024

ping

@bsumlin bsumlin merged commit 5b3d0a9 into bsumlin:master Dec 5, 2024
@bsumlin
Copy link
Owner

bsumlin commented Dec 5, 2024

Merged! Sorry for the delay.

@slayoo
Copy link

slayoo commented Dec 5, 2024

Thank you! Let me take the liberty to also ask for a PyPI release of the updated code, thanks!

@bsumlin
Copy link
Owner

bsumlin commented Dec 5, 2024

Will do!

@natsuwater
Copy link
Contributor Author

Thank you! I've double checked the installation from a cloned local repository and now PyMieScatt works fine, again.

@slayoo slayoo mentioned this pull request Dec 7, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants