Potential Witness Malleability Ordering Attack #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlobMaster41
force-pushed
the
feat/potential-exploit-txid
branch
from
a10859c to
981a532
Compare
Replaces usage of transactionIdString with transactionHashString throughout transaction processing and sorting logic. Adds txHashHex and transactionHashString properties to Transaction class for consistent access. Updates package.json to use @datastructures-js/priority-queue v6.3.5. Add separate tsconfig for tests and update main config Created tests/tsconfig.json to handle test files with noEmit option. Removed test file patterns from the main tsconfig.json 'include' array to separate configuration concerns. Refactor TransactionSorter tests and update tsconfig includes Replaces TransactionSorter tests with more comprehensive and deterministic test cases, focusing on witness malleability and dependency ordering. Removes tests/tsconfig.json and updates main tsconfig.json to include tests directory. Minor formatting and import cleanup in BlockIndexer.ts and vitest.config.ts. Add transaction reindexing feature and sorting improvements Introduces a transaction reindexing mode to reorder generic transactions within blocks, including new config options and validation. Refactors transaction sorting to use a generic interface, adds dependency-aware sorting, and updates storage interfaces for batch index updates. Also adds new files for transaction reindexing logic and sortable transaction abstraction.
BlobMaster41
force-pushed
the
feat/potential-exploit-txid
branch
from
e5bd5a7 to
8cb1bf1
Compare
Replaces non-null assertions with optional chaining in test files, extracts mock functions to avoid unbound-method warnings, and updates some test expectations for better type compatibility. Also formats the tests/tsconfig.json file for consistency.
Expanded TransactionSorter tests to cover various dependency and fee scenarios, including complex dependency trees, equal-fee sorting, and parent-child relationships. Introduced helper functions and new-style tests using the Transaction class to ensure correct transaction ordering logic.
Updated TransactionSorter tests to use 32-byte hex strings for txid and wtxid, ensuring deterministic ordering by computedIndexingHash. Adjusted test cases to reflect new input format and improved assertions for dependency and fee-based sorting.
BlobMaster41
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Witness Malleability Ordering Attack
Attack Mechanics
You're a miner. You create TX-Alpha-W1 and TX-Alpha-W2, same txid, different wtxid. You include both in the same block you mine. Bitcoin doesn't care, both are valid transactions with different wtxids, and Bitcoin deduplicates by wtxid not txid at the block level.
If OPNet orders by txid, it now has two transactions with identical ordering keys. The priority queue or sorting logic has two entries that compare equal on txid. The behavior is undefined or implementation-dependent, different nodes might process them in different orders based on insertion order, memory layout, or however the sort handles duplicates.
Potential Outcome
Consensus divergence. Some nodes execute W1 first, some execute W2 first. If contract state depends on execution order, network splits.