Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcd fails to remove tx from orphan pool if in a mined block. #166

Closed
dajohi opened this issue Aug 23, 2014 · 2 comments
Closed

btcd fails to remove tx from orphan pool if in a mined block. #166

dajohi opened this issue Aug 23, 2014 · 2 comments
Labels
bug enhancement

Comments

@dajohi
Copy link
Member

dajohi commented Aug 23, 2014

When btcd accepts a new block, it removes the transactions within that block from the mempool, but forgets to remove them from the orphan pool.
@davecgh
Copy link
Member

davecgh commented Aug 24, 2014

Thanks for the report. The orphan will eventually get removed from the pool since there is a maximum limit and eviction occurs after that, but I agree that it would be ideal to remove it immediately upon receipt of a block, just like it does for the regular pool.

@dajohi
Copy link
Member Author

dajohi commented Aug 28, 2014

Closing - #167 is a pull request.

@dajohi dajohi closed this as completed Aug 28, 2014
@davecgh davecgh mentioned this issue Sep 20, 2014
Closed
davecgh pushed a commit to davecgh/btcd that referenced this issue Jul 15, 2016
@alexlyp
[dcrctl] Clear terminal history (btcsuite#276)
9146525 
Fixes btcsuite#166 and Fixes btcsuite#104
kcalvinalvin added a commit to kcalvinalvin/btcd that referenced this issue Nov 29, 2024
@kcalvinalvin
Merge pull request btcsuite#166 from kcalvinalvin/2024-04-22-move-nod…
df15689 
…esmap-to-utreexobackends

blockchain, sizehelper: move size constants to sizehelper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davecgh @dajohi