Bugfix for issue #101 draft 0.1 #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,6 +147,7 @@ type peer struct { | |||
| knownAddresses map[string]bool | |||
| knownInventory *MruInventoryMap | |||
| knownInvMutex sync.Mutex | |||
| versionMutex sync.Mutex | |||
There was a problem hiding this comment.
Please put this at least close to what it protects it makes reading the structure definition simpler (and we haven't gotten to the point of rearranging structures for better cache footprint)
gsalgado
pushed a commit
to gsalgado/btcd
that referenced
this pull request
Jul 29, 2014
If a websocket client was already connected and the wallet and/or chain server is loaded into the rpc server (enabling the handlers specific to those components), the btcdconnected notifications were not being sent, and this could break clients that expected the notification. I'm not happy with this change, but since this is how notifications are currently done (unsolicited), and to not break compatibility yet, I'm adding these back in for now. Eventually, this notification will require explicit registration before it is received by a client. See issue btcsuite#84. Closes btcsuite#115.
kcalvinalvin
added a commit
to kcalvinalvin/btcd
that referenced
this pull request
Nov 29, 2024
…logs indexers: slience flatutreexoproofindex logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for the race caused when a peer tried to write and read to p.versionKnown concurrently.
To correct this, a new mutex and two functions were added for locking and subsequently reading or writing the state of versionKnown.