Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heavy rework on documentation #1468

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Heavy rework on documentation #1468

merged 1 commit into from
Sep 1, 2020

Conversation

legacycode
Copy link
Contributor

Hi,
i did a lot of restructuring the existing documentation. The documentation now automatically renders on readthedocks.io. I think this is a great new user experience :-)

I hope you like my suggestions. You can preview the new documentation at: https://btcd.readthedocs.io/

I like this kind of documentation. That was a lot of work. Hopefully this will be merged :-)
/legacycode

@octobocto
Copy link

octobocto commented Dec 6, 2019

readthedocs is very nice, maybe add a link to it in the main README?

I think it would be nice to delete docs/table_of_contents.md and rename docs/index.md to docs/README.md because README.md is a natural starting point, index is not

Copy link
Collaborator

@jakesylvestre jakesylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the merge conflict is resolvd

@legacycode
Copy link
Contributor Author

@jakesyl done

@jakesylvestre
Copy link
Collaborator

Thanks!

@jakesylvestre
Copy link
Collaborator

@jcvernaleo (as per #1530)

  • low priority
  • documentation

This probably does make sense to merge sooner rather than later since I've already had @legacycode rework this once and new PRs will likely cause conflicts that he'll have to deal with again

Copy link
Contributor

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for doing this! The btcd.readthedocs.io will probably show up in the top search results of Google, and this will serve as a great intro for people to get started.

I added some minor remarks. My global feedback is about filenames, which is very important since they get transformed into URLs directly. They should be:

  • Short (use abbreviations if required).
  • Use hyphenations, instead of underscores.

docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/code_contribution_guidelines.md Show resolved Hide resolved
docs/configuring_tor.md Show resolved Hide resolved
docs/developer_resources.md Show resolved Hide resolved
docs/update.md Show resolved Hide resolved
docs/json_rpc_api.md Show resolved Hide resolved
@onyb
Copy link
Contributor

onyb commented Aug 31, 2020

@legacycode Any update on this? The CI needs to be fixed in order to merge this.

@jakesylvestre
Copy link
Collaborator

That and needs to be rebased

@legacycode
Copy link
Contributor Author

@onyb @jakesyl Rebased and CI passed. Ready for merge :-)

@jakesylvestre
Copy link
Collaborator

LGTM!

@jakesylvestre jakesylvestre merged commit 355472b into btcsuite:master Sep 1, 2020
@legacycode
Copy link
Contributor Author

legacycode commented Sep 1, 2020

@jakesyl Great. I released the subdomain btc.readthedocs.org on https://readthedocs.org/dashboard/ Please make sure that somebody of your team create/administrate the project at readthedocs.org. It's a one time process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants