-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heavy rework on documentation #1468
Conversation
readthedocs is very nice, maybe add a link to it in the main README? I think it would be nice to delete docs/table_of_contents.md and rename docs/index.md to docs/README.md because README.md is a natural starting point, index is not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the merge conflict is resolvd
@jakesyl done |
Thanks! |
@jcvernaleo (as per #1530)
This probably does make sense to merge sooner rather than later since I've already had @legacycode rework this once and new PRs will likely cause conflicts that he'll have to deal with again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos for doing this! The btcd.readthedocs.io will probably show up in the top search results of Google, and this will serve as a great intro for people to get started.
I added some minor remarks. My global feedback is about filenames, which is very important since they get transformed into URLs directly. They should be:
- Short (use abbreviations if required).
- Use hyphenations, instead of underscores.
@legacycode Any update on this? The CI needs to be fixed in order to merge this. |
That and needs to be rebased |
LGTM! |
@jakesyl Great. I released the subdomain btc.readthedocs.org on https://readthedocs.org/dashboard/ Please make sure that somebody of your team create/administrate the project at readthedocs.org. It's a one time process. |
Hi,
i did a lot of restructuring the existing documentation. The documentation now automatically renders on readthedocks.io. I think this is a great new user experience :-)
I hope you like my suggestions. You can preview the new documentation at: https://btcd.readthedocs.io/
I like this kind of documentation. That was a lot of work. Hopefully this will be merged :-)
/legacycode