multi: move the btcutil repo into btcd as a sub-module #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I think we might actually need to do things in two phases:
|
5 tasks
Roasbeef
force-pushed
the
btcutil-move
branch
from
8760379 to
844f0b7
Compare
|
OK, so I might've found a way around things. Just pushed up a new version, builds for mew locally.... The change here is to not attempt to replace the main |
Pull Request Test Coverage Report for Build 1680556584
💛 - Coveralls |
In this commit, we move `btcutil` as well as its sub-module, the `psbt` package into the `btcd` repo itself.
In this commit, we update all the btcutil imports to point to the new sub-module. In the same commit, we also modify the recently added `btcutil/go.mod` file as we need to continue pointing to the _old_ version of btcd, until we merge this PR and push a new tag.
In this commit, we adapt the Makefile that was being used for the btcutil project to work for btcd as well. The Makefile is pretty simple, and is just a series of templated commands. Overtime, we can pull in some of the `lnd` additions as well, which we use to handle our reproducible build and verification system.
Roasbeef
force-pushed
the
btcutil-move
branch
from
844f0b7 to
3cacbd4
Compare
|
Looks like we had a build y'all! After this, it'll remove the old CI builds and have the newer ones instead be shown as required. |
This was referenced Jan 11, 2022
Roasbeef
added a commit
to Roasbeef/btcutil
that referenced
this pull request
Jan 26, 2022
After [this PR](btcsuite/btcd#1785) this repo is now deprecated as the code lives in `btcd` within a new sub-module. In this commit, we remove all the code, and update the README to point to the new location.
Roasbeef
added a commit
to Roasbeef/btcutil
that referenced
this pull request
Jan 26, 2022
After [this PR](btcsuite/btcd#1785) this repo is now deprecated as the code lives in `btcd` within a new sub-module. In this commit, we remove all the code, and update the README to point to the new location.
Roasbeef
added a commit
to Roasbeef/btcutil
that referenced
this pull request
Jan 29, 2022
After [this PR](btcsuite/btcd#1785) this repo is now deprecated as the code lives in `btcd` within a new sub-module. In this commit, we remove all the code, and update the README to point to the new location.
vpereira01
added a commit
to vpereira01/btcd
that referenced
this pull request
Feb 22, 2022
With PR btcsuite#1785 multiple coverage reports are sent to coveralls. This makes coveralls only conside the last report sent. This fix treat all reports has parallel reports so they can all be compiled later by coveralls.
vpereira01
added a commit
to vpereira01/btcd
that referenced
this pull request
Feb 22, 2022
With PR btcsuite#1785 multiple coverage reports are sent to coveralls. This makes coveralls only conside the last report sent. This fix treat all reports has parallel reports so they can all be compiled later by coveralls.
vpereira01
added a commit
to vpereira01/btcd
that referenced
this pull request
Feb 23, 2022
With PR btcsuite#1785 multiple coverage reports are sent to coveralls. This makes coveralls only consider the last report sent. This fix treat all reports has parallel reports so they can all be compiled later by coveralls.
This was referenced Feb 23, 2022
vpereira01
added a commit
to vpereira01/btcd
that referenced
this pull request
Mar 7, 2022
With PR btcsuite#1785 multiple coverage reports are sent to coveralls. This makes coveralls only consider the last report sent. This fix treat all reports has parallel reports so they can all be compiled later by coveralls.
jcvernaleo
pushed a commit
that referenced
this pull request
Mar 10, 2022
With PR #1785 multiple coverage reports are sent to coveralls. This makes coveralls only consider the last report sent. This fix treat all reports has parallel reports so they can all be compiled later by coveralls.
vpereira01
added a commit
to vpereira01/btcd
that referenced
this pull request
Mar 10, 2022
With PR btcsuite#1785 multiple coverage reports are sent to coveralls. This makes coveralls only consider the last report sent. This fix treat all reports has parallel reports so they can all be compiled later by coveralls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we move the
btcutilrepo into btcd itself as a sub-module, as suggested in #1777. With this change we won't need to retain the copy ofbtcec v1and can skip to using the `v2 version instead directly.Once this PR is merged, we'll need to push a
btcutil/v1.0.0tag. After that I can update thego.modin thebtcutilsub-module to use a replace directive as normal, since it needs to reference a version of the greaterbtcdmodule as is.If we don't want to finally bite the bullet and move over to having more sub-modules in
btcd, then I can modify the initial commit to just add the new package to the existing btcd super-module.The final commit borrows the
Makefilethatbtcutilborrowed from thelndrepo.