-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove circular dependency issue between btcec/v2
and main package
#1823
Conversation
Pull Request Test Coverage Report for Build 1956823903
💛 - Coveralls |
EDIT: Removed that commit again since the author of the original PR already pushed a fix. |
776f825
to
38a9b6d
Compare
I merged #1780, so I think this just needs a rebase now. I think we'll also need to tag new |
Weird, I think we've done this in the past? Though maybe there's some other sneaky interaction here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦟
Changes look good to me, if we really want to then we can eliminate the spew
dep, but that only relies on the std-lib, so it doesn't bring any new deps into the fray.
Needs aa rebase, then we can merge this and push out the new tags, then update the mod files in another PR. |
38a9b6d
to
999514c
Compare
Rebased! |
Fixes #1822.
After merging this PR we need to push two tags:
chaincfg/chainhash/v1.0.0
andbtcec/v2/v2.1.1
.And I think the two tags cannot be on the same commit (because go mod is just mean that way), so I'd suggest adding
chaincfg/chainhash/v1.0.0
to 7cc824e andbtcec/v2/v2.1.1
to 4ad74cd.cc @Roasbeef.