Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mining.md #1938

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Update mining.md #1938

merged 2 commits into from
Jan 20, 2023

Conversation

jagottsicher
Copy link
Contributor

minor changes to increase readability (easier copying) and a typo (echo needs double quotes if you want to add with >> append it to a file)

@jagottsicher
Update mining.md
27b6daa 
minor changes to increase readability and a typo (echo need double quotes if adding to a file)
@coveralls
Copy link

coveralls commented Jan 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3963241340

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 55.155%
Totals Coverage Status
Change from base Build 3903303371: 0.01%
Covered Lines: 26562
Relevant Lines: 48159
💛 - Coveralls

jcvernaleo
jcvernaleo requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like fixing the copy and paste part but I don't think the double quotes on line two are needed unless I'm missing something.

docs/mining.md Outdated Show resolved Hide resolved
@jagottsicher
Update mining.md
6f82493 
Implemented in pull request btcsuite#1938 requested change. Removed mistakenly added quotes.
@jagottsicher
Copy link
Contributor Author

put the quotes in again, commmited, and this pull request caught it.

jcvernaleo
jcvernaleo approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo
Copy link
Member

Once the github actions finish running I'll merge.

@jcvernaleo jcvernaleo merged commit 016b3ad into btcsuite:master Jan 20, 2023
@ygaberman-px ygaberman-px mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jagottsicher @coveralls @jcvernaleo