Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schnorr: bip-340 compliant verification #2018

Merged
merged 1 commit into from
Aug 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions btcec/schnorr/signature.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,7 @@ func ParseSignature(sig []byte) (*Signature, error) {
return nil, signatureError(ecdsa_schnorr.ErrSigRTooBig, str)
}
var s btcec.ModNScalar
if overflow := s.SetByteSlice(sig[32:64]); overflow {
str := "invalid signature: s >= group order"
return nil, signatureError(ecdsa_schnorr.ErrSigSTooBig, str)
}
s.SetByteSlice(sig[32:64])

// Return the signature.
return NewSignature(&r, &s), nil
Expand Down
Loading