Correct RPC time handling for getblocktemplate. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the getblocktemplate RPC to correctly handle the curtime field. Currently, the RPC server will refuse to serve a block template if the current time is before the minimum allowed time for a block even though the real generated block template already accounted for it. This consists of three changes: - Remove the unnecessary and incorrect check in the RPC invocation for the current time against the min required time since it is already handled properly by the block template generation. - Expose the network time source to the RPC work state and use the adjusted time for checking against the maximum allowed time instead of the current time. - Set the returned RPC result curtime field to the time of the generated block header. Fixes btcsuite#209.
|
ok |
kcalvinalvin
added a commit
to kcalvinalvin/btcd
that referenced
this pull request
Nov 29, 2024
…ch-blocks-from-equal-peers netsync: don't ask for blocks from peers on the same block height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the getblocktemplate RPC to correctly handle the curtime field.
Currently, the RPC server will refuse to serve a block template if the current time is before the minimum allowed time for a block even though the real generated block template already accounted for it.
This consists of three changes: