Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
to_spend
andto_sign
transactions in accordance to BIP-322 generic signed message format.EncodeWitness
function that encodes witness stack in a signed BIP-322 PSBT into base-64 encoded format.Additional Context
Depends on #2151
Closes #2077
How Has This Been Tested?
BuildToSpendTx
function with an empty message and "Hello World" message as in BIP-322BuildToSignTx
function with an empty message and "Hello World" message as in BIP-322.EncodeWitness
function where it encodes the input witnessFinalScriptWitness
of a finalizedto_sign
transaction into base64 and throws an error if theto_sign
transaction is not signed yet.Remaining Parts
I would greatly appreciate your feedback during this draft phase to ensure it aligns with the desired objectives. Thank you. 🙏