netsync: add handleBlockMsgHeadersFirst #2292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only exit headersFirstMode when we have no more checkpoints left. updateSyncPeer was resetting headersFirstMode by calling resetHeaderState only to have it turned back on with startSync(). Resetting the headers-first mode when we've not really exited the headers first mode will cause problems with later commits that add parallel block downloads so we remove it here.
We were still updating invs for peers but since during ibd new blocks and txs are irrelevant, don't bother updating either.
For headers first mode, there's no need for a global map of requested blocks since it's only used when we're caught up and need a quick way to check which blocks were requested instead of searching through all the requested blocks map for all the connected peers.
The headerList includes headers we've already downloaded and verified. Instead of resetting it and re-downloading them on syncPeer disconnects, we reset the startHeader to be the first header in the list so that we can re-use the headers and download the blocks associated with it.
We add a function to process blocks specifically in headers first mode. In headers first we can make different assumptions with the biggest being: 1: Downloading blocks out of order but processing them in order by caching blocks. 2: Error out when a block that doesn't past processing in headers first mode as the blocks are checkpointed.
Since blocks in headers-first mode is handled by handleBlockMsgHeadersFirst, we no longer need to handle headers first blocks in handleBlockMsg.
Pull Request Test Coverage Report for Build 12499244094Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-worked part of #2226 only containing the part for adding
handleBlockMsgHeadersFirst.The main purpose of this PR is to have code separated out from handling blocks during IBD vs out of IBD.
Since handling of the blocks can be very different in both of the cases, it's useful to separate out the block
handling code as well.