Process orphans on block acceptance. #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // transaction hash (it is possible that they are no longer orphans) and | ||
| // potentially accepts them to the memory pool. It repeats the process for the | ||
| // newly accepted transactions (to detect further orphans which may no longer be | ||
| // orphans) until there are no more. | ||
| // | ||
| // This function is safe for concurrent access. | ||
| func (mp *txMemPool) ProcessOrphans(hash *wire.ShaHash) error { |
There was a problem hiding this comment.
Define this after the thing is calls, please (processOrphans).
For every transaction in a newly accepted block, process the orphan pool moving now no longer orphan transactions to the mempool. Previously, no longer orphan transactions would remain in the orphan pool.
|
The concept looks sound to me. |
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every transaction in a newly accepted block, process the orphan
pool moving now no longer orphan transactions to the mempool.
Previously, no longer orphan transactions would remain in the orphan
pool.