txscript: Add new flag ScriptVerifyLowS #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -367,6 +377,44 @@ func (s *Script) checkHashTypeEncoding(hashType SigHashType) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *Script) checkLowDERSignature(sig []byte) error { | |||
There was a problem hiding this comment.
After reviewing more, I personally don't think this function should exist at all. Rather, the checkSignatureEncoding function should check the flag at the appropriate place and do the check there:
if s.verifyLowS { /* do the checks and return error if no good */ }I'd rather not check the signature (and bounds) multiple times.
The ScriptVerifyLowS flag defines that script signatures must comply with the DER format as well as have an S value less than or equal to the half order.
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ScriptVerifyLowS flag defines that script signatures must
comply with the DER format as well as have an S value less than
or equal to the half order.