txscript: Add exported opcode name to value map. #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than storing a separate bool for whether or not each flag is set in every script engine instance, store the flags and check if the relevant flag is set from each specific location. This reduces the memory needed by each script engine instance and means future flags will not require new fields.
This commit modifies the definition of the opcodes to their hex counterparts rather than decimal since it is far more common to see scripts in hex. This makes it easier when manually looking at script dumps to correlate opcodes. However, since there are also cases where it is useful to see the decimal value of the opcode, the decimal value has been left as a comment. Obviously converting the numbers is trivial, but it is handy when looking at the opcode definitions to already have it there. In addition, it syncs the opcodes with the latest Bitcoin Core internal opcodes for completeness and modifies the tests accordingly.
This commit converts the opcode map to an array to improve performance. Benchmark of executing a standard p2pk transaction: New: BenchmarkExecute 2000 784349 ns/op Old: BenchmarkExecute 2000 792600 ns/op The time is dominated by the signature checking as expected, however there is still an increase in speed.
This commit exports a new map named OpcodeByName which can be used to lookup an opcode value given a human-readable opcode name. It also modifies the test function which does short form parsing to use the new map instead of the internal array. Closes btcsuite#267.
davecgh
force-pushed
the
txscript_opcodebyname
branch
from
eafd9dd to
d66593b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #395.
This pull request exports a new map named OpcodeByName which can be used to lookup an opcode value given a human-readable opcode name.
It also modifies the test function which does short form parsing to use the new map instead of the internal array.
Closes #267.