txscript: Cleanup and improve opcode tests. #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davecgh
commented
Apr 28, 2015
davecgh
commented
- Remove all redundant opcode tests in favor of the JSON-based tests in the data directory.
- Remove duplicate stack nip test
- Add new tests to data/script_invalid.json to exercise additional negative error paths
- Remove old unneeded pubkey trace code from opcodeCheckSig
- Simplify and improve the disassembly print function
- Add new tests to directly test all individual opcode disassembly
- Add new tests to directly test opcode disabled function which does not get invoked during ordinary execution
- Improve test coverage of opcode.go
davecgh
force-pushed
the
txscript_cleanup_opcode_tests
branch
from
1e0f27e to
4e56bcd
Compare
- Remove all redundant opcode tests in favor of the JSON-based tests in the data directory. - Remove duplicate stack nip test - Add new tests to data/script_invalid.json to exercise additional negative error paths - Remove old unneeded pubkey trace code from opcodeCheckSig - Simplify and improve the disassembly print function - Add new tests to directly test all individual opcode disassembly - Add new tests to directly test opcode disabled function which does not get invoked during ordinary execution - Improve test coverage of opcode.go
davecgh
force-pushed
the
txscript_cleanup_opcode_tests
branch
from
4e56bcd to
8ef68dc
Compare
cjepson
added a commit
to cjepson/btcd
that referenced
this pull request
Oct 7, 2016
Sidechain and orphan blocks were given in previous version of the software in response to the RPC command getblock, in line with bitcoind. Insight relied on this functionality. It has been restored in 0.5.0. Fixes btcsuite#406.
cjepson
added a commit
to cjepson/btcd
that referenced
this pull request
Oct 7, 2016
Sidechain and orphan blocks were given in previous version of the software in response to the RPC command getblock, in line with bitcoind. Insight relied on this functionality. It has been restored in 0.5.0. Fixes btcsuite#406.
cjepson
added a commit
to cjepson/btcd
that referenced
this pull request
Oct 11, 2016
Sidechain and orphan blocks were given in previous version of the software in response to the RPC command getblock, in line with bitcoind. Insight relied on this functionality. It has been restored in 0.5.0. Fixes btcsuite#406.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.