txscript: Implement CheckLockTimeVerify (BIP0065) #459
Conversation
|
This requires #455 first. |
| @@ -413,6 +415,8 @@ var opcodeArray = [256]opcode{ | |||
| OP_ENDIF: {OP_ENDIF, "OP_ENDIF", 1, opcodeEndif}, | |||
| OP_VERIFY: {OP_VERIFY, "OP_VERIFY", 1, opcodeVerify}, | |||
| OP_RETURN: {OP_RETURN, "OP_RETURN", 1, opcodeReturn}, | |||
| OP_CHECKLOCKTIMEVERIFY: {OP_CHECKLOCKTIMEVERIFY, | |||
There was a problem hiding this comment.
I know the code is generally kept to 80, but I think for consistency, given every other entry, even those that are longer, are on a single line, this one should be too.
|
Aside from the minor things I pointed out, this looks good. I manually decoded each of the tx tests (both valid and invalid) and verified they are testing the intended things. I also did a thorough comparison audit since this will ultimately affect consensus. Finally, the test coverage from the tests is sufficient to cover all branches in the new function:
|
|
Consensus wise it appears correct. Made a couple nits but they're just my suggestions. Not too happy with copying Core's comments verbatim. |
See https://github.com/bitcoin/bips/blob/master/bip-0065.mediawiki for more information. This commit mimics Bitcoin Core commit bc60b2b4b401f0adff5b8b9678903ff8feb5867b and includes additional tests from Bitcoin Core commit cb54d17355864fa08826d6511a0d7692b21ef2c9
|
Comments updated w/ help from @davecgh |
|
OK |
This commit mimics Bitcoin Core commit bc60b2b4b401f0adff5b8b9678903ff8feb5867b and includes additional tests from cb54d17355864fa08826d6511a0d7692b21ef2c9.