Implmement BlockHeader BtcEncode/BtcDecode. #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,6 +156,81 @@ func TestBlockHeaderWire(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // TestBlockHeaderBtcEncode tests BlockHeader encode and decode. | |||
| func TestBlockHeaderBtcEncode(t *testing.T) { | |||
There was a problem hiding this comment.
I'd prefer not having a separate test func here. Just add the relevant encode/decode bits to TestBlockHeaderWire. Also, the name doesn't match what the function does anyways since it's testing both encode/decode.
For example, after the call to
err := wire.TstWriteBlockHeader(&buf, test.pver, test.in)
...
if !bytes.Equal(buf.Bytes(), test.buf) {
...Add:
+ err = test.in.BtcEncode(&buf, pver)
+ if err != nil { ... }
+ if !bytes.Equal(buf.Bytes(), test.buf) { ... }Then the same deal for the decode.
At the current time, there is no difference between the wire encoding at protocol version 0 and the stable long-term storage format. These methods are simply for consistency with the other types.
|
Looks good now. OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the current time, there is no difference between the wire encoding
at protocol version 0 and the stable long-term storage format. These
methods are simply for consistency with the other types.