peer: Don't log write errs due to disconnect. #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
no_peer_write_err_on_dc
branch
4 times, most recently
from
f205136 to
6b0c6ed
Compare
|
I think we discussed this one on irc. As stated there, I'm in favor of relatively clean logs at the 'normal' level so I like this change. |
davecgh
force-pushed
the
no_peer_write_err_on_dc
branch
from
6b0c6ed to
4a397d5
Compare
This commit modifies the peer logging so that it will not log an error when it's due to the remote peer disconnecting or the peer being forcibly disconnected or shutdown.
davecgh
pushed a commit
to davecgh/btcd
that referenced
this pull request
Dec 23, 2016
* Bump block header version to 3. * Enforce new rules once block version gets to 3. * Use Voter Versions to control bumping of Stake Version. * Calculate appropriate stake version based on history and prior intervals in the mining code. * Add bunch of UT to validate code. This is the minimally correct working implementation. This code desperately needs to memoize the questions that are asked repeatedly. Fixes btcsuite#523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #445
This pull request modifies the peer logging so that it will not log an error when it's due to the remote peer disconnecting or the peer being forcibly disconnected or shutdown.