Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer: Improve documentation. #528

Merged
merged 1 commit into from
Oct 23, 2015
Merged

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Oct 23, 2015

This fleshes out the doc.go documentation which is shown on godoc, the README.md shown on github, and improves a couple of comments for the fields in the Config struct.

Review on Reviewable

@tuxcanfly
Copy link
Contributor

Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.


peer/doc.go, line 27 [r1] (raw file):
typo: "responsible"


peer/doc.go, line 47 [r1] (raw file):
"the" repeated


peer/README.md, line 32 [r1] (raw file):
typo: "responsible"


peer/README.md, line 52 [r1] (raw file):
"the" repeated


Comments from the review on Reviewable.io

@tuxcanfly
Copy link
Contributor

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.


Comments from the review on Reviewable.io

This fleshes out the doc.go documentation which is shown on godoc, the
README.md shown on github, and improves a couple of comments for the
fields in the Config struct.
@tuxcanfly
Copy link
Contributor

OK, looks good.


Reviewed 2 of 2 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@conformal-deploy conformal-deploy merged commit 250228c into btcsuite:master Oct 23, 2015
@davecgh davecgh deleted the peerdoc branch December 30, 2015 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants