Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcwallet 0.13 wtxmgr go.mod require needs update #780

Closed
chappjc opened this issue Nov 23, 2021 · 1 comment
Closed

btcwallet 0.13 wtxmgr go.mod require needs update #780

chappjc opened this issue Nov 23, 2021 · 1 comment

Comments

@chappjc
Copy link
Contributor

chappjc commented Nov 23, 2021

github.com/btcsuite/btcwallet/wtxmgr v1.3.0

The tagged btcwallet v0.13.0 currently specifies wtxmgr v1.3.0 in the go.mod, however a newer revision of wtxmgr that has the InsertTxCheckIfExists method is actually required. A consumer must add a replace to their project's go.mod if they wish to use btcwallet v0.13.0. e.g.

github.com/btcsuite/btcwallet/wtxmgr v1.3.1-0.20211113022102-559f6eff0e52

Consumers can work around this as above, but perhaps a tag and updated require is something for the next patch release. I find that when tagging releases, that removing replace statements is helpful to smoke out such things, however minor they are.

Alternatively, btcwallet might consider removing wtxmgr as a standalone module, in favor of absorbing it into the main module. I'm not familiar with use cases for wtxmgr that might be sensible without the root module in use as well.

@chappjc chappjc changed the title btcwallet 0.13 btxmgr go.mod require needs update btcwallet 0.13 wtxmgr go.mod require needs update Nov 23, 2021
@chappjc
Copy link
Contributor Author

chappjc commented Dec 1, 2021

Specifically, I guess I'm requesting:

  • a wtxmgr/v1.4.0 tag
  • updated go.mod so the main btcwallet module uses that
  • a v0.13.1 tag for the main btcwallet module, preferably at a revision with replace statements removed to confirm the requires are sufficient

I'm eager to update to v0.13, but it is somewhat awkward to need a replace or require to hoist the wtxmgr module to a newer untagged revision.

Thanks! The 0.13 change list looks really nice. In particular I'm curious about if and how 34da5cf affects peering for light clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant