Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wtxmgr require for a replace-free release #782

Closed
wants to merge 3 commits into from

Conversation

chappjc
Copy link
Contributor

@chappjc chappjc commented Dec 3, 2021

Resolves #780

This is essentially what I would propose to resolve issue #780.
Except, there would ideally be a wtxmgr/v1.4.0 tag instead of a require to for an untagged revision.

The btcd required update is not strictly necessary, and should actually probably be skipped.
On the other hand, the neutrino update to v0.13.0 is more important as there is a critical bug fixed in that release.

This updates the wtxmgr require so that the main btcwall may be built
without being in the repository root, such as from another package's
reuire or via go install.

The also removes the ginko replace because neither btcd or btcwallet
require it, not any more anyway.
This updates the btcd and neutrino requires.

The btcd update brings the txhelpers performance improvements.

The neutrino update fixes a bug with block-filter validation
that can break the chain service when filtering blocks with
certain transactions, such as those spending taproot outputs.
This was referenced Jan 25, 2022
@chappjc
Copy link
Contributor Author

chappjc commented Feb 4, 2022

Closing since other module tasks related to the new btcd/btcutil submodule that will obsolete these changes.

I would just respectfully request that either (a) the next tagged release could be cut without the replaces so that Go consumers (not just the btcwallet app when built from the root of the repository) can require the btcwallet module without additional replace or require directives to get compatible wtxmgr etc. submodules, or (b) ensure that any replaces aren't needed to build.

Plus it's nice for install instructions if you could do go install to get the btcwallet app without manually checking out the workspace and building from the main module folder (repo root).

$  go install -v github.com/btcsuite/btcwallet@v0.13.0
go install: github.com/btcsuite/btcwallet@v0.13.0 (in github.com/btcsuite/btcwallet@v0.13.0):
	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

Also would be good to bump the versions in version.go.

I appreciate all the effort to maintain btcwallet in the age of cumbersome Go modules. Thanks!

@chappjc chappjc closed this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

btcwallet 0.13 wtxmgr go.mod require needs update
1 participant