Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(title): change default title to Rollup #143

Merged
merged 2 commits into from
Dec 21, 2022
Merged

fix(title): change default title to Rollup #143

merged 2 commits into from
Dec 21, 2022

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Dec 20, 2022

This is how it's styled in the repo of Rollup itself (and already in the readme)

source: https://github.com/rollup/rollup

This is how it's styled in the repo of Rollup itself (and already in the readme)

source: https://github.com/rollup/rollup
@btd
Copy link
Owner

btd commented Dec 20, 2022

Hi. I am fine with change, but you need to change also

const filename = opts.filename ?? chooseDefaultFileName(opts);

@Haroenv
Copy link
Contributor Author

Haroenv commented Dec 20, 2022

Thanks, I didn't see the second result in my search for it. Updated!

@btd btd merged commit c871e71 into btd:master Dec 21, 2022
@Haroenv Haroenv deleted the patch-1 branch December 21, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants