Support for javascript enclosures?

[thardy]

I'm trying to follow better javascript patterns espoused by "the greats" like Douglas Crockford, and I found that using enclosures breaks ngmin..

(function(app) {
    app.controller('SomeController', function ($scope) {
    });
}(angular.module("someModule")));

It never sees the controller declaration and leaves it alone. Should this be working?

[btford]

I'm not keen on this. I don't think this pattern buys you anything.

Try ngmin with --dynamic.

[eddiemonge]

You can get the same enclosures doing it this way:

(function(angular) {
    angular.module("someModule").controller('SomeController', function ($scope) {
    });
}(window.angular);

but really the enclosure could/should(?) be added by your build system after concatenating your code

[eddiemonge]

Please try https://github.com/olov/ng-annotate. ngmin is now deprecated: #93

If your issue isn't resolved there please open an issue at https://github.com/olov/ng-annotate/issues

If you really want ngmin to fix this issue, feel free to fork it and use that.