fix: delay loading of percentageFromCfi until displayedCFI is ready.

btpf · Jul 5, 2024 · 24a6b4d · 24a6b4d
1 parent c711611
commit 24a6b4d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/routes/Reader/ProgressMenu/ProgressMenu.tsx b/src/routes/Reader/ProgressMenu/ProgressMenu.tsx
@@ -106,7 +106,11 @@ const ProgressInfoBar = ()=>{
     }
 
   }
-
+
+  // wait until displayedCFI is loaded
+  if (!displayedCFI) {
+    return <BottomMenuContainer active={menuActive}></BottomMenuContainer>;
+  }
   const currentPercentage = renditionInstance?.book.locations.percentageFromCfi(displayedCFI)
 
   const locationsCount = renditionInstance?.book.locations.total
@@ -130,4 +134,4 @@ const ProgressInfoBar = ()=>{
   )
 }
 
-export default ProgressInfoBar
+export default ProgressInfoBar
diff --git a/src/routes/Reader/Reader.tsx b/src/routes/Reader/Reader.tsx
@@ -196,7 +196,7 @@ const Home = () =>{
         <div onClick={()=>{
           dispatch(ToggleProgressMenu())
         }} className={styles.percentageContainer}>
-          {renditionInstance? Math.round(renditionInstance.book.locations.percentageFromCfi(displayedCFI)*100):"0"}%
+          {displayedCFI && renditionInstance? Math.round(renditionInstance.book.locations.percentageFromCfi(displayedCFI)*100):"0"}%
         </div>
         <div className={styles.sliderContainer}>
           <SliderNavigator/>