Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security alert for lodash dependancy version #123

Closed
KlapTrap opened this issue Apr 23, 2019 · 5 comments
Closed

Security alert for lodash dependancy version #123

KlapTrap opened this issue Apr 23, 2019 · 5 comments

Comments

@KlapTrap
Copy link

See https://app.snyk.io/test/npm/ngrx-store-localstorage/7.0.0 for the report.

@bufke
Copy link
Collaborator

bufke commented May 25, 2019

Related issue. championswimmer/vuex-persist#114

Ideally we'd just not use lodash at all. But implementing a deep merge function is not trivial. I looked at lodash-es but it requires a lot of complicated webpack set up to get any actual benefit. Open to suggestions here.

@bufke
Copy link
Collaborator

bufke commented May 27, 2019

I recommend we solve this by switching to deepmerge instead. However this would require testing and validation from the community.

@bufke
Copy link
Collaborator

bufke commented May 28, 2019

@KlapTrap would you be interested in trying out the deepmerge branch and verifying it works as expected? I'd like as much review on this as possible.

@KlapTrap
Copy link
Author

@bufke Sorry for the late reply. Thanks for look into this. We've been using https://github.com/cf-stratos/ngrx-store-localstorage/tree/lodash-dep-update as a temporary work around. I'll look into switching to the deep merge branch today and get back to you asap.

@bufke
Copy link
Collaborator

bufke commented Jul 25, 2019

Fixed in 8.0

@bufke bufke closed this as completed Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants