Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype Pollution vulnerabilities #114

Open
AnandChowdhary opened this issue May 5, 2019 · 4 comments
Open

Prototype Pollution vulnerabilities #114

AnandChowdhary opened this issue May 5, 2019 · 4 comments

Comments

@AnandChowdhary
Copy link

The dependency lodash.merge has a high severity vulnerability.

Source: https://app.snyk.io/vuln/SNYK-JS-LODASHMERGE-173732

Seems like using lodash instead of lodash.merge is safer: ztoben/assets-webpack-plugin@9632e0c (Is it?)

@championswimmer
Copy link
Owner

championswimmer commented May 5, 2019 via email

@bufke
Copy link

bufke commented May 25, 2019

lodash.merge doesn't seem to be getting updated anymore. Using lodash instead would have a big impact on bundle size. 😢

@bufke
Copy link

bufke commented May 25, 2019

@championswimmer the issue you had with deepmerge was arrays were concat'ed right? That seems like a fixable issue.

Did you have any other issues? I'm helping maintain ngrx-store-localstorage and facing the same issue. I went with lodash specifically because I saw you had trouble with deepmerge.

@championswimmer
Copy link
Owner

championswimmer commented May 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants