Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for nrgx 8 / Angular 8? #129

Closed
dstj opened this issue Jun 7, 2019 · 2 comments
Closed

Support for nrgx 8 / Angular 8? #129

dstj opened this issue Jun 7, 2019 · 2 comments

Comments

@dstj
Copy link

dstj commented Jun 7, 2019

Hi,

ngrx 8.0.0 has a minimum dependency of Angular 8

V8 has the minimum version requirements:

Angular version 8.x
Angular CLI version 8.0.2
TypeScript version 3.4.x
RxJS version 6.5.x

But ngrx-store-localstorage does not support it yet:

npm WARN ngrx-store-localstorage@7.0.0 requires a peer of @ngrx/store@^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 but none is installed. You must install peer dependencies yourself.

Any plans to update?
@dstj dstj changed the title Support for Angular 8? Support for nrgx 8 / Angular 8? Jun 7, 2019
wdunn001 added a commit to wdunn001/ngrx-store-localstorage that referenced this issue Jun 16, 2019
@wdunn001
btroncone#129 updating peer dependencies
bc6f2c3
bufke added a commit that referenced this issue Jun 16, 2019
@bufke
Merge pull request #131 from wdunn001/patch-1
8e0ea51 
#129 updating peer dependencies
@isaacplmann
Copy link

It looks like the peer dependencies have been updated in package.json, but we need a new version pushed to npm.

Thanks!

@btroncone
Copy link
Owner

Just cut a new release for this, it should be available now 👍

BovineEnthusiast pushed a commit to beocommedia/ngrx-store-localstorage that referenced this issue Oct 29, 2019
Merge branch 'master' of https://github.com/btroncone/ngrx-store-loca…
01800c9 
…lstorage

* 'master' of https://github.com/btroncone/ngrx-store-localstorage:
  Update CHANGELOG.md
  Update CHANGELOG.md
  chore(release): release version 8.0.0
  Try replacing lodash with deepmerge (btroncone#126)
  Update CHANGELOG.md
  chore(release): 7.0.1
  btroncone#129 updating peer dependencies
  Add Angular Universal support by checking if browserSide fix btroncone#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dstj @isaacplmann @btroncone