Added checkFirstPage and checkLastPage functions in navigation.js to … #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handle hiding and showing tooltip for navigation buttons.
|
I dont want to hide the tooltips. see: ariakit/ariakit#471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…handle hiding and showing tooltip for navigation buttons.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #196
What is the current behavior?
Tooltip will show on disabled button to change pages (last and first pages).
What is the new behavior?
No tooltip will be shown on disabled button for page navigation.
Other information
Note that tooltip only remains visible after moving mouse off if the button is disable. Tooltip does not remain visible after moving mouse off if the button is active.